[webkit-reviews] review denied: [Bug 33570] [BREWMP] Map FastMalloc to BREW memory allocator : [Attachment 48099] FastMalloc

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 4 16:56:47 PST 2010


Eric Seidel <eric at webkit.org> has denied Kwang Yul Seo
<kwangyul.seo at gmail.com>'s request for review:
Bug 33570: [BREWMP] Map FastMalloc to BREW memory allocator
https://bugs.webkit.org/show_bug.cgi?id=33570

Attachment 48099: FastMalloc
https://bugs.webkit.org/attachment.cgi?id=48099&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Hmmm.

Why use a #define instead of  just naming the functions malloc, calloc, etc?

Maybe this code should go in its own header, which FastMalloc.cpp should
include.  Something like SystemMallocBrew.h?

How do other codebases which port to BREW deal with this strange lack of
malloc()?


More information about the webkit-reviews mailing list