[webkit-reviews] review denied: [Bug 33568] [BREWMP] Port vprintf_stderr_common : [Attachment 47481] Port vprintf_stderr_common

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Kwang Yul Seo
<kwangyul.seo at gmail.com>'s request for review:
Bug 33568: [BREWMP] Port vprintf_stderr_common
https://bugs.webkit.org/show_bug.cgi?id=33568

Attachment 47481: Port vprintf_stderr_common 
https://bugs.webkit.org/attachment.cgi?id=47481&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
I probably would have made the while loop its own function which took a
Vector<char>& and knew how to walk the vector spitting out chunks to the debug
stream.

This should probably just be "static":
 123	 char printBuffer[printBufferSize + 1];

Can VSNPRINTF ever return < 0?	If so, then this code can deadlock.

I guess I would have used buffer.size() to bound my while loop instead of the
return value from VSNPRINTF.  That way you know for sure that you never walk
off the end of the Vector.