[webkit-reviews] review granted: [Bug 14227] Scroll does not work with IBM Thinkpad : [Attachment 48054] Patch

[bugzilla-daemon at webkit.org]

Steve Falkenburg <sfalken at apple.com> has granted Brian Weinstein
<bweinstein at apple.com>'s request for review:
Bug 14227: Scroll does not work with IBM Thinkpad
https://bugs.webkit.org/show_bug.cgi?id=14227

Attachment 48054: Patch
https://bugs.webkit.org/attachment.cgi?id=48054&action=review

------- Additional Comments from Steve Falkenburg <sfalken at apple.com>
> +    Frame* frame = m_page->focusController()->focusedOrMainFrame();

You can move this line down to near the end of the method (in both horizontal
and vertical scrolling methods).

> +bool WebView::shouldInitializeTrackPointHack()
> +{
> +    static bool shouldCreateScrollbars = false;
> +    static bool hasRunTrackPointCheck = false;

No need to init these - they will be inited to false for you.

> +    shouldCreateScrollbars = false;

This is already false.