[webkit-reviews] review granted: [Bug 34518] [BREWMP] Implement OwnPtrBrew to make sure BREW instances are freed. : [Attachment 48006] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 3 12:59:50 PST 2010


Eric Seidel <eric at webkit.org> has granted Kwang Yul Seo
<kwangyul.seo at gmail.com>'s request for review:
Bug 34518: [BREWMP] Implement OwnPtrBrew to make sure BREW instances are freed.
https://bugs.webkit.org/show_bug.cgi?id=34518

Attachment 48006: Patch
https://bugs.webkit.org/attachment.cgi?id=48006&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Seems we should eventually share more code between things like this and GOwnPtr
or RetainPtr.  No need for each platform to copy/paste.

If you'd like to file a bug about such code sharing, that'd be great.

This looks fine to me.


More information about the webkit-reviews mailing list