[webkit-reviews] review requested: [Bug 34527] Improve/maintain Haiku port : [Attachment 48037] HaikuLauncher minimal browser shell

[bugzilla-daemon at webkit.org]

Stephan Aßmus <superstippi at gmx.de> has asked  for review:
Bug 34527: Improve/maintain Haiku port
https://bugs.webkit.org/show_bug.cgi?id=34527

Attachment 48037: HaikuLauncher minimal browser shell
https://bugs.webkit.org/attachment.cgi?id=48037&action=review

------- Additional Comments from Stephan Aßmus <superstippi at gmx.de>
This patch adds an implementation for the Haiku browser shell. There was no
previous implementation checked into the repository, except for the
WebCoreSupport classes. There are minimal changes there, but the important
detail of the HaikuLauncher code is that it uses an offscreen bitmap/view
combination to perform drawing, and that any events which happen in the window
thread are forwarded to a new class WebProcess, which is an event handler in
the main thread. Thus, all calls into WebKit happen on the main thread. Except
for keyboard input, the HaikuLauncher is functional. Some sites result in
"about:blank" to be loaded halfway through loading the site (but without
actually showing an about:blank page). After such an event, the shell becomes
unusable and will soon crash when calling some pure virtual method.