[webkit-reviews] review granted: [Bug 33248] WebSocket should close the connection when unloading the document : [Attachment 47998] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Fumitoshi Ukai
<ukai at chromium.org>'s request for review:
Bug 33248: WebSocket should close the connection when unloading the document
https://bugs.webkit.org/show_bug.cgi?id=33248

Attachment 47998: Patch
https://bugs.webkit.org/attachment.cgi?id=47998&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
Nice test! r=me

> +	   WebSocket should close the connection when unloading the document

One thing I'm not quite sure about - how does the HTML5 "unload the document"
concept correspond to detaching a frame? Maybe we should make one or two more
variations of this test - in one, we'd force garbage collection after detaching
subframe; in another, we'd keep a reference to frames[0].document, making sure
that it outlives the frame.