[webkit-reviews] review requested: [Bug 34527] Improve/maintain Haiku port : [Attachment 48032] Implementing PathHaiku and GradientHaiku, fleshing out GraphicsContextHaiku

[bugzilla-daemon at webkit.org]

Stephan Aßmus <superstippi at gmx.de> has asked  for review:
Bug 34527: Improve/maintain Haiku port
https://bugs.webkit.org/show_bug.cgi?id=34527

Attachment 48032: Implementing PathHaiku and GradientHaiku, fleshing out
GraphicsContextHaiku
https://bugs.webkit.org/attachment.cgi?id=48032&action=review

------- Additional Comments from Stephan Aßmus <superstippi at gmx.de>
The patch can be applied individually, but cannot be broken into smaller
pieces.

PathHaiku was irritatingly implemented as BRegion, while BRegion has nothing to
do with paths. BShape is the way to go. I've implemented the subset of
functionality that can be implemented using BShape.

PathGradient was previously not implemented at all. I've taken the Qt
implementation as a reference and websites using gradients seem to render fine.


GraphicsContextHaiku was not implementing a great deal of functionality. The
patch implements

 * partial support for paths and gradients
 * more clipping methods
 * support for round rects
 * support for transparency layers
 * support for translating the context, as needed for scrolling
 * changes the strokeArc() method to produce beautiful arcs as needed for box
elements
   without the need to implement clipping paths.
 * implements filling rects
 * implements rounding to device pixels
 * a few missing new methods that broke the build on Haiku
 * fixes a few warnings