[webkit-reviews] review canceled: [Bug 27813] [Qt] DumpRenderTree lacks pixel tests support : [Attachment 48028] proposed fix

[bugzilla-daemon at webkit.org]

Ariya Hidayat <ariya.hidayat at gmail.com> has canceled Csaba Osztrogonac
<ossy at webkit.org>'s request for review:
Bug 27813: [Qt] DumpRenderTree lacks pixel tests support
https://bugs.webkit.org/show_bug.cgi?id=27813

Attachment 48028: proposed fix
https://bugs.webkit.org/attachment.cgi?id=48028&action=review

------- Additional Comments from Ariya Hidayat <ariya.hidayat at gmail.com>
> +	   [Qt] DumpRenderTree lacks pixel tests support
> +	   https://bugs.webkit.org/show_bug.cgi?id=27813

Maybe provide the description of your fix, rather then the bug?

> +    m_expectedHash = QString();
> +    if (m_dumpPixels) {
> +	   // single quote marks the pixel dump hash
> +	   int i = line.indexOf('\'');
> +	   if (i > -1) {
> +	       m_expectedHash = line.mid(i + 1, line.length());
> +	       line.remove(i, line.length());
> +	   }
> +    }

Looks good.

> -		   if (written == block)
> -		       break;

This is because it is ported from other DRT. Maybe check why this exists
elsewhere?