[webkit-reviews] review granted: [Bug 34409] Use WTF::getLocalTime instead of localtime_r in FTPDirectoryDocument : [Attachment 47951] Use WTF::getLocalTime

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Kwang Yul Seo
<kwangyul.seo at gmail.com>'s request for review:
Bug 34409: Use WTF::getLocalTime instead of localtime_r in FTPDirectoryDocument
https://bugs.webkit.org/show_bug.cgi?id=34409

Attachment 47951: Use WTF::getLocalTime 
https://bugs.webkit.org/attachment.cgi?id=47951&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +using WTF::getLocalTime;

Thanks for changing this, but it's still not quite right. This needs to go at
the bottom of CurrentTime.h with the other "using" that is already there. But
as I said last time, I will not insist it goes there in this patch. It might be
more pleasant to have this patch not touch JavaScriptCore.

>  #if PLATFORM(QT) && defined(Q_WS_WIN32)
> -// Defined in FTPDirectoryDocument.cpp.
> -struct tm gmtimeQt(const QDateTime &input);
> +
> +// Replacement for gmtime_r() which is not available on MinGW.
> +// We use this on all of Qt's platforms for portability.

The code above says "use this only on Win 32", but the comment says "on all of
Qt's platforms". The comment should match the #if.

r=me because I think it's OK to land even with these mistakes, but I cleared
commit-queue because I think we'll probably go another round