[webkit-reviews] review denied: [Bug 34492] avoid using invalidated KURL object in Element::baseURI : [Attachment 47952] patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Bryan Yeung <bryeung at chromium.org>'s
request for review:
Bug 34492: avoid using invalidated KURL object in Element::baseURI
https://bugs.webkit.org/show_bug.cgi?id=34492

Attachment 47952: patch
https://bugs.webkit.org/attachment.cgi?id=47952&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Change looks great, although I’d probably use assignment syntax rather than
initialization to set up the baseAttribute local variable.

Generally it's not correct to set the review flag on a patch without a change
log entry.

We require regression tests for bugs fixes. Since this patch fixes a bug, you
must also include a regression test that fails on Chromium before this change
and now succeeds with the fix. But neither the test itself nor the test results
should be Chromium-specific.

review- because of the lack of change log and regression test