[webkit-reviews] review denied: [Bug 32770] [GTK] Spell check works on selection but it should work on unselected words : [Attachment 45240] Pass a string to Editor and make GTK+ not use the selected text but the text in the node. #2

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Christian Dywan
<christian at twotoasts.de>'s request for review:
Bug 32770: [GTK] Spell check works on selection but it should work on
unselected words
https://bugs.webkit.org/show_bug.cgi?id=32770

Attachment 45240: Pass a string to Editor and make GTK+ not use the selected
text but the text in the node. #2
https://bugs.webkit.org/attachment.cgi?id=45240&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
This would break the Mac build:
/Users/abarth/git/webkit-queue/WebCore/editing/Editor.cpp: In member function
'WTF::Vector<WebCore::String, 0ul>
WebCore::Editor::guessesForMisspelledOrUngrammaticalSelection(bool&, bool&,
const WebCore::String&, const WebCore::HitTestResult&)':
/Users/abarth/git/webkit-queue/WebCore/editing/Editor.cpp:2173: error: cannot
convert 'const WebCore::String' to 'WebCore::Range*' for argument '2' to
'WTF::Vector<WebCore::String, 0ul>
WebCore::guessesForMisspelledOrUngrammaticalRange(WebCore::EditorClient*,
WebCore::Range*, bool, bool&, bool&)'
cc1plus: warnings being treated as errors
/Users/abarth/git/webkit-queue/WebCore/editing/Editor.cpp: At global scope:
/Users/abarth/git/webkit-queue/WebCore/editing/Editor.cpp:2170: warning: unused
parameter 'result'