[webkit-reviews] review denied: [Bug 34450] [Qt] Enable a way to measure FPS in QGVLauncher : [Attachment 47871] Add a command line argument to enable crude FPS measurements in QGVLauncher

[bugzilla-daemon at webkit.org]

Ariya Hidayat <ariya.hidayat at gmail.com> has denied Noam Rosenthal
<noam.rosenthal at nokia.com>'s request for review:
Bug 34450: [Qt] Enable a way to measure FPS in QGVLauncher
https://bugs.webkit.org/show_bug.cgi?id=34450

Attachment 47871: Add a command line argument to enable crude FPS measurements
in QGVLauncher
https://bugs.webkit.org/attachment.cgi?id=47871&action=review

------- Additional Comments from Ariya Hidayat <ariya.hidayat at gmail.com>
> +	   ,
m_measureFps(QApplication::instance()->arguments().contains("--fps"))

Maybe --show-fps is a better name?

> +	   QTime now = QTime::currentTime();
> +	   int msecs = m_startTime.msecsTo(now);
> +	   int totalMsecs = m_totalStartTime.msecsTo(now);
> +	   int totalFps = m_numTotalPaints * 1000 / totalMsecs;
> +	   int curFps = m_numPaintsSinceLastMeasure * 1000 / msecs;

Please guard against divide-by-zero (yes, that might happen accidently :)

r- for this minor issues. Otherwise, looks good.