[webkit-reviews] review denied: [Bug 51753] Web Inspector: move delayed search implementation to SourceFrame : [Attachment 77682] Patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 31 03:42:20 PST 2010


Pavel Feldman <pfeldman at chromium.org> has denied Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 51753: Web Inspector: move delayed search implementation to SourceFrame
https://bugs.webkit.org/show_bug.cgi?id=51753

Attachment 77682: Patch.
https://bugs.webkit.org/attachment.cgi?id=77682&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=77682&action=review

> WebCore/ChangeLog:5
> +	   Web Inspector: move delayed search implementation to SourceFrame.

I think search support should either be implemented in SourceView or
SourceFrame. I see no reason for having it split between the two. I'm fine with
both: having it implemented in SourceFrame or in SourceView.


More information about the webkit-reviews mailing list