[webkit-reviews] review denied: [Bug 51738] Web Inspector: refactoring: encapsulate lazy initialization of SourceFrame : [Attachment 77685] Patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 31 04:13:08 PST 2010


Pavel Feldman <pfeldman at chromium.org> has denied Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 51738: Web Inspector: refactoring: encapsulate lazy initialization of
SourceFrame
https://bugs.webkit.org/show_bug.cgi?id=51738

Attachment 77685: Patch.
https://bugs.webkit.org/attachment.cgi?id=77685&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=77685&action=review

> WebCore/inspector/front-end/SourceFrame.js:835
> +	   var sourceIDToStartingLineMap =
this._contentProvider.sourceIDToStartingLineMap();

You will be able to use short for syntax if you make properties on Array's
prototype non-enumerable:
Object.defineProperty(Array.prototype, "remove", { value: function() { ... }});
By default it'll create non-writable, non-enumerable, non-configurable
property.

> WebCore/inspector/front-end/SourceFrame.js:874
> +    sourceIDToStartingLineMap: function()

This is a very strange content provider. I'd suggest to provide Scripts array
here: you can then get both ids and starting lines from the scripts.


More information about the webkit-reviews mailing list