[webkit-reviews] review granted: [Bug 51716] [GTK] Initial build support for WebGL : [Attachment 77633] Initial WebGL build support

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 29 18:36:04 PST 2010


Eric Seidel <eric at webkit.org> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 51716: [GTK] Initial build support for WebGL
https://bugs.webkit.org/show_bug.cgi?id=51716

Attachment 77633: Initial WebGL build support
https://bugs.webkit.org/attachment.cgi?id=77633&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=77633&action=review

In general looks fine, but needs more explanation (in code) as to what is
permenant and what is temporary? (if any).  In general looks fine.

> WebCore/platform/graphics/GraphicsContext3D.h:70
> +#undef VERSION
> +#undef None

Huh?

> WebCore/platform/graphics/GraphicsContext3D.h:74
> +typedef unsigned int GLuint;
> +typedef void* PlatformGraphicsContext3D;
> +const PlatformGraphicsContext3D NullPlatformGraphicsContext3D = 0;
> +typedef GLuint Platform3DObject;

Should these be shared between implementations?  Seems they all define he
same...


More information about the webkit-reviews mailing list