[webkit-reviews] review granted: [Bug 50716] Update validation of stencil mask and ref values : [Attachment 77631] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 29 18:34:19 PST 2010


Kenneth Russell <kbr at google.com> has granted Zhenyao Mo <zmo at google.com>'s
request for review:
Bug 50716: Update validation of stencil mask and ref values
https://bugs.webkit.org/show_bug.cgi?id=50716

Attachment 77631: Patch
https://bugs.webkit.org/attachment.cgi?id=77631&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=77631&action=review

Looks good; one cleanup upon landing please.

> WebCore/html/canvas/WebGLRenderingContext.cpp:1119
> +    if (m_stencilMask != m_stencilMaskBack || m_stencilFuncRef !=
m_stencilFuncRefBack || m_stencilFuncMask != m_stencilFuncMaskBack) {
> +	   m_context->synthesizeGLError(GraphicsContext3D::INVALID_OPERATION);
> +	   return;
> +    }
> +

Could you please refactor these tests into a helper function similar to
validateDrawMode?


More information about the webkit-reviews mailing list