[webkit-reviews] review granted: [Bug 51569] [GTK] EditorClient::generateEditorCommands queues up "null string" commands : [Attachment 77454] Patch for this issue

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 51569: [GTK] EditorClient::generateEditorCommands queues up "null string"
commands
https://bugs.webkit.org/show_bug.cgi?id=51569

Attachment 77454: Patch for this issue
https://bugs.webkit.org/attachment.cgi?id=77454&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=77454&action=review

> WebKit/gtk/WebCoreSupport/EditorClientGtk.cpp:666
> +	if (!mapKey)

When is this condition ever true?  I would have put an assertion here unless
you know a condition in which map key is 0.