[webkit-reviews] review requested: [Bug 50122] Add an overload to base64Encode with String output : [Attachment 77466] Alternative Patch

[bugzilla-daemon at webkit.org]

Patrick R. Gansterer <paroga at paroga.com> has asked  for review:
Bug 50122: Add an overload to base64Encode with String output
https://bugs.webkit.org/show_bug.cgi?id=50122

Attachment 77466: Alternative Patch
https://bugs.webkit.org/attachment.cgi?id=77466&action=review

------- Additional Comments from Patrick R. Gansterer <paroga at paroga.com>
(In reply to comment #3)
> (From update of attachment 74961 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=74961&action=review
> 
> Yeah.  Seems we just want to return the String.  All the callsites want that.
:)
> 
> > WebCore/platform/text/Base64.h:40
> > +void base64Encode(const char*, unsigned, String&, bool insertLFs = false);

> 
> Why not just return the String?
I wanted to keep all the callsites consistent (pass the output argument instead
of returning), but it makes sense to return String directly