[webkit-reviews] review granted: [Bug 51490] Cleanup SVG code according to the webkit style rules 3 : [Attachment 77309] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has granted Dirk Schulze <krit at webkit.org>'s
request for review:
Bug 51490: Cleanup SVG code according to the webkit style rules 3
https://bugs.webkit.org/show_bug.cgi?id=51490

Attachment 77309: Patch
https://bugs.webkit.org/attachment.cgi?id=77309&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=77309&action=review

r=me with one small thing and one medium:

> WebCore/ChangeLog:8
> +	   Last patch to fix indention and other style issues according to the
WebKit style rules in the SVG code.

s/indention/indentation/

> WebCore/svg/SVGSVGElement.cpp:133
> -    double _x = 0.0;
> -    double _y = 0.0;
> +    double m_x = 0.0;
> +    double m_y = 0.0;

This looks quite wrong, m_x and m_y are member variables, and you are shadowing
them here.
Use better names please :)