[webkit-reviews] review denied: [Bug 51509] [Qt] [Symbian] Fix build-webkit script for Symbian : [Attachment 77281] proposed patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Laszlo Gombos
<laszlo.1.gombos at nokia.com>'s request for review:
Bug 51509: [Qt] [Symbian] Fix build-webkit script for Symbian
https://bugs.webkit.org/show_bug.cgi?id=51509

Attachment 77281: proposed patch
https://bugs.webkit.org/attachment.cgi?id=77281&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=77281&action=review

Review tool can't seem to apply the patch, so I doubt this will land w/o an
update.

> Tools/Scripts/webkitdirs.pm:303
> +	   # Symbian builds do not have Release/Debug configurations either.
> +	   if (($ENV{"WEBKITOUTPUTDIR"} && (isGtk() || isEfl())) ||
isSymbian()) {

We need to make this into a function.  usesPerConfigurationBuildDirectory() or
similar.

> Tools/Scripts/webkitdirs.pm:1526
> -    my $dir = File::Spec->canonpath(baseProductDir());
> -    $dir = File::Spec->catfile($dir, $config) unless isSymbian();
> +    my $dir = File::Spec->canonpath(productDir());

Is this a symbian specific code path? Otherwise why is this OK for other ports?


> Tools/Scripts/webkitdirs.pm:1532
> -    push @buildArgs, "OUTPUT_DIR=" . baseProductDir() . "/$config";
> +    push @buildArgs, "OUTPUT_DIR=" . $dir;

Why is this OK for other ports?  Or is this just reverting previously added
symbian-specific code?