[webkit-reviews] review denied: [Bug 51474] [Qt][WK2] WebProcess does not clean up on termination : [Attachment 77241] Patch - with the new files

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 22 11:33:44 PST 2010


Kenneth Rohde Christiansen <kenneth at webkit.org> has denied  review:
Bug 51474: [Qt][WK2] WebProcess does not clean up on termination
https://bugs.webkit.org/show_bug.cgi?id=51474

Attachment 77241: Patch - with the new files
https://bugs.webkit.org/attachment.cgi?id=77241&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=77241&action=review

I think Kimmo should look at this before it is being committed. Also I do not
like that you do renaming and all these changes in the same patch... it is very
hard to see what was actually changed. The rename could easily be another
patch. R- for this reason.

> WebKit2/Platform/qt/SharedMemoryQt.cpp:139
> +    // Do not leave behind the shared memory segment!

Comments should not end with ! They should just be informative.

> WebKit2/Platform/qt/SharedMemoryQt.cpp:147
> +    CleanupHandler::instance()->willDelete(m_impl);

I do not like the name willDelete... I dont understand what it actually does.


More information about the webkit-reviews mailing list