[webkit-reviews] review denied: [Bug 51484] KURL constructor incorrectly asserts with file://localhost URLs : [Attachment 77242] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 22 11:38:29 PST 2010


Alexey Proskuryakov <ap at webkit.org> has denied Jeff Miller <jeffm at apple.com>'s
request for review:
Bug 51484: KURL constructor incorrectly asserts with file://localhost URLs
https://bugs.webkit.org/show_bug.cgi?id=51484

Attachment 77242: Patch
https://bugs.webkit.org/attachment.cgi?id=77242&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
This assertion means that the ParsedURLString form of the constructor is only
used with parsed URLs - i.e. with a result of KURL::string(). If course, it
assumes that URL parsing is idempotent.


More information about the webkit-reviews mailing list