[webkit-reviews] review granted: [Bug 51258] TouchEvents does not support multi-touch on a page with multiple touch targets : [Attachment 77201] Patch 4 - corrects expected results to only have one TEST COMPLETE

[bugzilla-daemon at webkit.org]

Steve Block <steveblock at google.com> has granted Jonathan Dixon
<joth at chromium.org>'s request for review:
Bug 51258: TouchEvents does not support multi-touch on a page with multiple
touch targets
https://bugs.webkit.org/show_bug.cgi?id=51258

Attachment 77201: Patch 4 - corrects expected results to only have one TEST
COMPLETE
https://bugs.webkit.org/attachment.cgi?id=77201&action=review

------- Additional Comments from Steve Block <steveblock at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=77201&action=review

> WebCore/page/EventHandler.cpp:2860
> +	   RefPtr<Node> node = result.innerNode();

Why do we now take a reference? Is this required?

> WebCore/page/EventHandler.cpp:2943
> +	       RefPtr<TouchList> targetTouches(state ==
PlatformTouchPoint::TouchCancelled ? emptyList :
touchesByTarget.get(touchEventTarget));

Would it be clearer to have a isTouchCancelEvent boolean set up outside this
inner loop?