[webkit-reviews] review canceled: [Bug 51452] check-webkit-style shouldn't complaint about underscores in variables in objective C files. : [Attachment 77194] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 22 07:34:59 PST 2010


David Levin <levin at chromium.org> has canceled  review:
Bug 51452: check-webkit-style shouldn't complaint about underscores in
variables in objective C files.
https://bugs.webkit.org/show_bug.cgi?id=51452

Attachment 77194: Patch
https://bugs.webkit.org/attachment.cgi?id=77194&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Landed as http://trac.webkit.org/changeset/74478.

Agreed with Shinichiro that we can make the check more strict in another patch.
(It will be nice to get rid of this false positive now and I suspect the issue
of underscores in variables is a less common mistake for Objective C
programmers.)


More information about the webkit-reviews mailing list