[webkit-reviews] review granted: [Bug 51438] Can't stop QT music on santastreefarm.com : [Attachment 77174] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 51438: Can't stop QT music on santastreefarm.com
https://bugs.webkit.org/show_bug.cgi?id=51438

Attachment 77174: Patch
https://bugs.webkit.org/attachment.cgi?id=77174&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=77174&action=review

> WebKit2/WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:773
> +static NPBool NPN_ConvertPoint(NPP npp, double sourceX, double sourceY,
NPCoordinateSpace sourceSpace, double* destX, double* destY, NPCoordinateSpace
destSpace)

I hate the name npp!

> WebKit2/WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:101
> +    switch (sourceSpace) {

Wow, are all these cases covered in testing?

> WebKit2/WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:120
> +	   sourceYInScreenSpace = [[[NSScreen screens] objectAtIndex:0]
frame].size.height - sourceY;

Seems like we should use a helper function instead of repeating this twice.
WebCore has a helper for this, but you could just use a local one.