[webkit-reviews] review granted: [Bug 51437] Add a way to get a web archive in WebKit2 : [Attachment 77173] Patch

[bugzilla-daemon at webkit.org]

Brady Eidson <beidson at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 51437: Add a way to get a web archive in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=51437

Attachment 77173: Patch
https://bugs.webkit.org/attachment.cgi?id=77173&action=review

------- Additional Comments from Brady Eidson <beidson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=77173&action=review

> WebKit2/ChangeLog:15
> +	   (WebKit::WebPageProxy::getWebArchiveForFrame): Added.

Not going to r- based on this, but consider it - I slightly prefer
"getWebArchiveOfFrame" instead of "getWebArchiveForFrame"

Same comment applies throughout

> WebKit2/WebProcess/WebPage/WebPage.cpp:951
> +

It seems weird that every platform has this family of functionality even if
they don't support our concept of a "WebArchive," and that makes this silent
"never really do anything here" behavior puzzling to me for non-Mac/Win builds.


I don't know a good solution for this without a whole-lot-more #ifdef'ing