[webkit-reviews] review requested: [Bug 51293] WebKit does not build with worker but without the javascript debugger : [Attachment 76941] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Dec 18 13:21:35 PST 2010
Benjamin Poulain <benjamin.poulain at nokia.com> has asked for review:
Bug 51293: WebKit does not build with worker but without the javascript
debugger
https://bugs.webkit.org/show_bug.cgi?id=51293
Attachment 76941: Patch
https://bugs.webkit.org/attachment.cgi?id=76941&action=review
------- Additional Comments from Benjamin Poulain <benjamin.poulain at nokia.com>
To fix the build, I could have modified the idl to move the two functions
outside of ENABLE_JAVASCRIPT_DEBUGGER, like they were before #51025.
Instead I added guards in InspectorController. Those two functions are in the
context of the Debugger, so the change of #51025 make sense in my opinion, and
we can remove the calls to those methods.
More information about the webkit-reviews
mailing list