[webkit-reviews] review canceled: [Bug 51250] Web Inspector: introduce enabled/disabled flag for each domain handler : [Attachment 76882] [patch] initial version

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Dec 18 11:35:52 PST 2010


Pavel Feldman <pfeldman at chromium.org> has canceled Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 51250: Web Inspector: introduce enabled/disabled flag for each domain
handler
https://bugs.webkit.org/show_bug.cgi?id=51250

Attachment 76882: [patch] initial version
https://bugs.webkit.org/attachment.cgi?id=76882&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
This looks good, except for... I'd rather start with domain agents refactorings
to make them independent and switchable on/off. Otherwise you risk ending up
with a nice flag that means nothing (i.e. can't be backed up with proper
implementation). Like turning off "Backend" is impossible. Or having CSS with
no DOM is impossible. Give me some time to think about it please.


More information about the webkit-reviews mailing list