[webkit-reviews] review requested: [Bug 51150] WebView's _scaleWebView SPI doesn't work on pages with compositing layers : [Attachment 76714] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 15 17:23:35 PST 2010


Beth Dakin <bdakin at apple.com> has asked  for review:
Bug 51150: WebView's _scaleWebView SPI doesn't work on pages with compositing
layers
https://bugs.webkit.org/show_bug.cgi?id=51150

Attachment 76714: Patch
https://bugs.webkit.org/attachment.cgi?id=76714&action=review

------- Additional Comments from Beth Dakin <bdakin at apple.com>
Simon was worried that docWidth and docHeight might be incorrect at times --
especially if they could ever be negative. I feel confident that they are
correct here because of Hyatt's description in the ChangeLog for r73885:
"RenderView now uses docLeft/Top/Height/Width functions, which are just
overflow queries that account for writing modes.  These methods are now the
preferred way to query for the physical dimensions of a document." Also, all of
the layout tests pass, and I did some testing on LTR and RTL web sites with
compositing layers.


More information about the webkit-reviews mailing list