[webkit-reviews] review requested: [Bug 34884] [Qt] QWebSettings::setUserStyleSheetUrl() does not work with windows paths that contain drive letters : [Attachment 76715] Proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Dec 15 17:29:29 PST 2010
Jarred Nicholls <jarred.nicholls at gmail.com> has asked for review:
Bug 34884: [Qt] QWebSettings::setUserStyleSheetUrl() does not work with windows
paths that contain drive letters
https://bugs.webkit.org/show_bug.cgi?id=34884
Attachment 76715: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=76715&action=review
------- Additional Comments from Jarred Nicholls <jarred.nicholls at gmail.com>
QUrl::toLocalFile() is perfectly sufficient right here. KURL::path() returns a
extra leading slash for Windows file URIs, but QUrl::toLocalFile() will handle
these well.
A separate bug will be filed for allowing style sheet files as qrc resource
URIs, which involves changing WebCore/page/Page.cpp.
More information about the webkit-reviews
mailing list