[webkit-reviews] review denied: [Bug 50617] ValidityState's exposed functions should check if willValidate() is true before all : [Attachment 76362] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Dai Mikurube
<dmikurube at google.com>'s request for review:
Bug 50617: ValidityState's exposed functions should check if willValidate() is
true before all
https://bugs.webkit.org/show_bug.cgi?id=50617

Attachment 76362: Patch
https://bugs.webkit.org/attachment.cgi?id=76362&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=76362&action=review

> LayoutTests/fast/css/pseudo-required-optional-005.html:28
> +shouldBeFalse('isGreenFor("submit")');

This is wrong.	Submit button doesn't support "required" attribute.  So
":optional" class should be applied to the element.

Also, the name "isGreenFor" is not good.  "isOptional" would be helpful.

> LayoutTests/fast/css/pseudo-valid-unapplied.html:69
> +shouldBe('getBackgroundColor("input-submit")', "invalidColor");
> +shouldBe('getBackgroundColor("input-image")', "normalColor");
> +shouldBe('getBackgroundColor("fieldset")', "normalColor");
> +shouldBe('getBackgroundColor("object")', "normalColor");
> +shouldBe('getBackgroundColor("button")', "invalidColor");

This test file is for "unapplied" cases.  Input-submit and button should be
moved to another test file.