[webkit-reviews] review denied: [Bug 50888] build-webkit --minimal --enable-video doesn't enable video : [Attachment 76321] proposed patch

[bugzilla-daemon at webkit.org]

Csaba Osztrogonac <ossy at webkit.org> has denied Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 50888: build-webkit --minimal --enable-video doesn't enable video
https://bugs.webkit.org/show_bug.cgi?id=50888

Attachment 76321: proposed patch
https://bugs.webkit.org/attachment.cgi?id=76321&action=review

------- Additional Comments from Csaba Osztrogonac <ossy at webkit.org>
It doesn't work, because there isn't --enable-video option in build-webkit
script.
You can use --video to enable and --no-video to disable video support.

This code sets the default value or 0 if you passed --minimal option :
...
# Initialize values from defaults
foreach (@features) {
    ${$_->{value}} = ($_->{default} && !$minimal) || 0;
}
...

But the script processes the command line arguments later:
...
# Build usage text and options list from features
foreach (@features) {
    my $opt = sprintf("%-35s", "  --[no-]$_->{option}");
    $usage .= "$opt $_->{desc} (default: $_->{default})\n";
    $options{"$_->{option}!"} = $_->{value};
}
...

So "build-webkit --minimal --video" will work for you and it isn't a bug.