[webkit-reviews] review denied: [Bug 46283] Allow CSS animations to run at more than 40FPS : [Attachment 75616] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Dec 12 02:30:52 PST 2010


Eric Seidel <eric at webkit.org> has denied Noam Rosenthal
<noam.rosenthal at nokia.com>'s request for review:
Bug 46283: Allow CSS animations to run at more than 40FPS
https://bugs.webkit.org/show_bug.cgi?id=46283

Attachment 75616: Patch
https://bugs.webkit.org/attachment.cgi?id=75616&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=75616&action=review

> WebCore/page/animation/AnimationController.cpp:46
> +double AnimationController::s_animationTimerDelay = 0.025;

Please document what this value means.	It's not even clear what the units are
(although I'm assuming seconds).

> WebKit/qt/Api/qgraphicswebview.cpp:252
> +    Settings::setAnimationTimerDelay(0.0167);

Please make it clearer what this value means.


More information about the webkit-reviews mailing list