[webkit-reviews] review denied: [Bug 50635] [new-run-webkit-tests] expectations parsing is slow : [Attachment 75825] proposed patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 50635: [new-run-webkit-tests] expectations parsing is slow
https://bugs.webkit.org/show_bug.cgi?id=50635

Attachment 75825: proposed patch
https://bugs.webkit.org/attachment.cgi?id=75825&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=75825&action=review

Well, instead this causes us to stat the file system for each path.  I guess
we're doing so right above, so the inode should be cached...

Would this be faster/just as fast if we just compiled a regexp for the path
first?

How did you perf test this?  How much speedup did you see?

>
WebKitTools/Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:7
23
> +	   if not os.path.isfile(path):

I guess I would have reversed this if to be positive instead of negative.

>
WebKitTools/Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:7
25
> +	       result = [ test for test in self._full_test_list if
test.startswith(path) ]

I don't think PEP8 says we put extra spaces around [ ] like this.