[webkit-reviews] review denied: [Bug 49355] WebGLRenderingContext needs to zero textures and renderbuffers : [Attachment 75761] revised patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has denied Zhenyao Mo <zmo at google.com>'s
request for review:
Bug 49355: WebGLRenderingContext needs to zero textures and renderbuffers
https://bugs.webkit.org/show_bug.cgi?id=49355

Attachment 75761: revised patch
https://bugs.webkit.org/attachment.cgi?id=75761&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=75761&action=review

> WebCore/html/canvas/WebGLRenderingContext.cpp:2534
> +	   zero = adoptArrayPtr(new unsigned char[size]);
> +	   memset(zero.get(), 0, size);

This construct is repeated many times throughout this code. It would be cleaner
to use OwnFastMallocPtr<T> in conjunction with fastZeroedMalloc. The only issue
is that OwnFastMallocPtr doesn't have a default constructor or assignment
operator. Please go ahead and add them, and use them instead. (I don't think
it's necessary to add a PassOwnFastMallocPtr class, just an assignment operator
taking T*.)