[webkit-reviews] review denied: [Bug 50712] make starting the websocket server more reliable on windows : [Attachment 75972] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Tony Chang <tony at chromium.org>'s
request for review:
Bug 50712: make starting the websocket server more reliable on windows
https://bugs.webkit.org/show_bug.cgi?id=50712

Attachment 75972: Patch
https://bugs.webkit.org/attachment.cgi?id=75972&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=75972&action=review

> WebKitTools/Scripts/webkitpy/common/system/filesystem.py:115
> +	   try:
> +	       WindowsError
> +	   except NameError:
> +	       WindowsError = FileSystem._WindowsError

Does this work on non-windows python?  Should we even be executing this code
for non-windows users?

> WebKitTools/Scripts/webkitpy/common/system/filesystem.py:126
> +	   raise OSError("failed to delete %s" % path)

Seems we should just re-raise the original WindowsError in that case, no?

> WebKitTools/Scripts/webkitpy/common/system/filesystem_unittest.py:156
> +	   FileSystemTest._remove_failures = 2

Can this just be a local?

> WebKitTools/Scripts/webkitpy/layout_tests/port/http_server_base.py:83
> +		   filesystem.remove(full_path)

This can't work?  remove is an instance method.