[webkit-reviews] review denied: [Bug 50331] ASSERT failing restoring scroll position from HistoryItem after reload : [Attachment 75287] Patch proposal

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Mario Sanchez Prada
<msanchez at igalia.com>'s request for review:
Bug 50331: ASSERT failing restoring scroll position from HistoryItem after
reload
https://bugs.webkit.org/show_bug.cgi?id=50331

Attachment 75287: Patch proposal
https://bugs.webkit.org/attachment.cgi?id=75287&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=75287&action=review

This needs a test.

> WebCore/loader/FrameLoader.cpp:2408
> +	       // If the user had a scroll point, scroll to it,
> +	       // overriding the anchor point if any. Also, make sure
> +	       // there's a valid current item in the history before
> +	       // trying to scroll because it could happen there was none
> +	       // (e.g. loading from a string instead of an URI).
> +	       if (m_frame->page() && history()->currentItem()) {

Seems rather overzealous line wrapping. :)