[webkit-reviews] review denied: [Bug 50341] Progressbar rendering crash : [Attachment 75387] Fixed the style.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 3 10:28:29 PST 2010


Eric Seidel <eric at webkit.org> has denied sadrul at chromium.org's request for
review:
Bug 50341: Progressbar rendering crash
https://bugs.webkit.org/show_bug.cgi?id=50341

Attachment 75387: Fixed the style.
https://bugs.webkit.org/attachment.cgi?id=75387&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=75387&action=review

> WebCore/ChangeLog:13
> +	   No new tests. (OOPS!)

This will block the commit-queue.  Is this not testable?  Please replace this
line with a description of what tests this affects.

> WebCore/rendering/RenderThemeChromiumSkia.cpp:844
> +	   if (width < 1)

It seems like you just want std::min here.


More information about the webkit-reviews mailing list