[webkit-reviews] review requested: [Bug 50412] http://www.wunderground.com/US/CA/Hayward.html causes big memory spike during page loading : [Attachment 75418] avoid flattening ropes when creating substrings

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 2 15:12:03 PST 2010


Antti Koivisto <koivisto at iki.fi> has asked  for review:
Bug 50412: http://www.wunderground.com/US/CA/Hayward.html causes big memory
spike during page loading
https://bugs.webkit.org/show_bug.cgi?id=50412

Attachment 75418: avoid flattening ropes when creating substrings
https://bugs.webkit.org/attachment.cgi?id=75418&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
Creating a substring caused the original string be flattened if it was in the
rope form. This could use significant amount of memory by reducing buffer
sharing between strings.
	
Add a rope specific substring function that constructs the substring by reusing
the rope fibers instead of flattening the rope.
	
No change observed in SunSpider.


More information about the webkit-reviews mailing list