[webkit-reviews] review granted: [Bug 49952] First steps to adding web audio files to build systems : [Attachment 75399] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Dec 2 15:11:25 PST 2010
Kenneth Russell <kbr at google.com> has granted Chris Rogers
<crogers at google.com>'s request for review:
Bug 49952: First steps to adding web audio files to build systems
https://bugs.webkit.org/show_bug.cgi?id=49952
Attachment 75399: Patch
https://bugs.webkit.org/attachment.cgi?id=75399&action=review
------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=75399&action=review
Looks good as much as can be determined without trying builds on all platforms.
r=me with one issue addressed.
> WebCore/WebCore.gyp/WebCore.gyp:149
> + '../platform/audio/win',
The mac and win include directories should be added in the OS-specific blocks
further below this one.
More information about the webkit-reviews
mailing list