[webkit-reviews] review denied: [Bug 44767] [EFL] WebCore depends on symbols from WebKit : [Attachment 65737] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Lucas De Marchi
<demarchi at webkit.org>'s request for review:
Bug 44767: [EFL] WebCore depends on symbols from WebKit
https://bugs.webkit.org/show_bug.cgi?id=44767

Attachment 65737: Patch
https://bugs.webkit.org/attachment.cgi?id=65737&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=65737&action=prettypatch

> WebCore/page/ContextMenuClient.h:60
> +#elif PLATFORM(EFL)
> +	   virtual PlatformMenuDescription
createPlatformDescription(ContextMenu*) = 0;
> +	   virtual void freePlatformDescription(PlatformMenuDescription) = 0;
> +	   virtual void appendItem(PlatformMenuDescription, ContextMenuItem&) =
0;
> +	   virtual void show(PlatformMenuDescription menu) = 0;
I'm not sure we should have platform specific methods here.  I see that Mac
does it, but that doesn't mean it's a good pattern.