[webkit-reviews] review denied: [Bug 40651] Use "typedef wchar_t JSChar" when compiled with RVCT : [Attachment 65732] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Kwang Yul Seo
<kwangyul.seo at gmail.com>'s request for review:
Bug 40651: Use "typedef wchar_t JSChar" when compiled with RVCT
https://bugs.webkit.org/show_bug.cgi?id=40651

Attachment 65732: Patch
https://bugs.webkit.org/attachment.cgi?id=65732&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=65732&action=prettypatch

> JavaScriptCore/wtf/unicode/qt4/UnicodeQt4.h:59
> -#if defined(Q_OS_WIN) || COMPILER(WINSCW) || (COMPILER(RVCT) && OS(SYMBIAN))

> +#if defined(Q_OS_WIN) || COMPILER(WINSCW) || (COMPILER(RVCT) && !OS(LINUX))
It's unclear to me why we're switching from a whitelist to a blacklist for
something that's identified as a hack...