[webkit-reviews] review granted: [Bug 44258] [EFL] Webkit-EFL API which returns position of n-th text matches mark. : [Attachment 65228] patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Kamil Blank <k.blank at samsung.com>'s
request for review:
Bug 44258: [EFL] Webkit-EFL API which returns position of n-th text matches
mark.
https://bugs.webkit.org/show_bug.cgi?id=44258

Attachment 65228: patch
https://bugs.webkit.org/attachment.cgi?id=65228&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
> WebKit/efl/ewk/ewk_frame.cpp:830
> +static bool _ewk_frame_rect_cmp_less_than(const WebCore::IntRect& i, const
WebCore::IntRect& j)
> +{
> +    return (i.y() < j.y() || (i.y() == j.y() && i.x() < j.x()));
> +}   
We generally frown upon one letter variable names.