[webkit-reviews] review denied: [Bug 44426] [Images] Fix related to image down sampling in cairo port : [Attachment 65234] Proposed solution

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 30 16:38:17 PDT 2010


Adam Barth <abarth at webkit.org> has denied Karol Kosacki
<k.kosacki at samsung.com>'s request for review:
Bug 44426: [Images] Fix related to image down sampling in cairo port
https://bugs.webkit.org/show_bug.cgi?id=44426

Attachment 65234: Proposed solution
https://bugs.webkit.org/attachment.cgi?id=65234&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Is there some reason we can't make a test for this patch?  We either need a
test or an explanation about why we can't make one.

> WebCore/ChangeLog:10
> +	   No new tests. (OOPS!)
This will prevent this patch from landing.

> WebCore/platform/graphics/cairo/ImageCairo.cpp:94
> +static void adjustSourceRectForDownSampling(FloatRect& srcRect, const
IntSize& origSize, const IntSize& scaledSize)
origSize => originalSize?


More information about the webkit-reviews mailing list