[webkit-reviews] review granted: [Bug 43179] [Qt] NPAPI Plugin metadata should be cached, and loading a plugin should not require loading every plugin : [Attachment 65553] Plugin metadata cache version 3

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Kimmo Kinnunen
<kimmo.t.kinnunen at nokia.com>'s request for review:
Bug 43179: [Qt] NPAPI Plugin metadata should be cached, and loading a plugin
should not require loading every plugin
https://bugs.webkit.org/show_bug.cgi?id=43179

Attachment 65553: Plugin metadata cache version 3
https://bugs.webkit.org/attachment.cgi?id=65553&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
WebCore/plugins/PluginDatabase.cpp:532
 +	// there's error in the cache, we won't try to load it anymore.x
Seems that an x crept in here :-(

WebKit/qt/Api/qwebplugindatabase.cpp:287
 +	    if (plugin->ensurePluginLoaded())
So if someone requests a list of installed plugins, we force load them all?

WebCore/plugins/PluginDatabase.h:107
 +	    bool m_persistentMetadataCacheLoaded;
I think we normally use the form "IsLoaded"

WebCore/plugins/PluginDatabase.cpp:488
 +	} while (1);
while (true) ? :-) 

Sure you don't want to move the setting to WebCore::Settings?