[webkit-reviews] review granted: [Bug 44471] [GTK] ScrollbarThemeGtk is incomplete : [Attachment 65191] Add theme-based painting for GTK+ scrollbars
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Aug 26 06:54:24 PDT 2010
Gustavo Noronha (kov) <gns at gnome.org> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 44471: [GTK] ScrollbarThemeGtk is incomplete
https://bugs.webkit.org/show_bug.cgi?id=44471
Attachment 65191: Add theme-based painting for GTK+ scrollbars
https://bugs.webkit.org/attachment.cgi?id=65191&action=review
------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
LGTM. The only thing that looks problematic to me is this:
56 // We do not support multiple steppers per end yet.
57 if (part == BackButtonEndPart)
58 return IntRect();
Though we don't seem to be regressing from our previous state, and thankfully
themes sporting more than one button per side seem to have gone out of fashion
=).
More information about the webkit-reviews
mailing list