[webkit-reviews] review granted: [Bug 44597] [GTK] Rework event definition in the DOM bindings : [Attachment 65390] eventdom.diff

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 25 11:31:53 PDT 2010


Martin Robinson <mrobinson at webkit.org> has granted Xan Lopez
<xan.lopez at gmail.com>'s request for review:
Bug 44597: [GTK] Rework event definition in the DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=44597

Attachment 65390: eventdom.diff
https://bugs.webkit.org/attachment.cgi?id=65390&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
WebCore/bindings/scripts/CodeGeneratorGObject.pm:612
 +	    foreach my $attribute (@eventSignalNames) {

I think this temporary variable should be called something like 
eventSignalName instead of attribute (copy and paste issue?). r=me with this
change.


More information about the webkit-reviews mailing list