[webkit-reviews] review requested: [Bug 44133] Implement an XHR.responseBlob accessor : [Attachment 65449] xhr.responseBlob bindings

[bugzilla-daemon at webkit.org]

Michael Nordman <michaeln at google.com> has asked  for review:
Bug 44133: Implement an XHR.responseBlob accessor
https://bugs.webkit.org/show_bug.cgi?id=44133

Attachment 65449: xhr.responseBlob bindings
https://bugs.webkit.org/attachment.cgi?id=65449&action=review

------- Additional Comments from Michael Nordman <michaeln at google.com>
Ooops... use UNUSED_PARAM(ec) in the responseText(ExceptionCode& ec) and
responseXML(ExceptionCode& ec) methods when XHR_RESPONSE_BLOB is not enabled.

-const ScriptString& XMLHttpRequest::responseText() const
+const ScriptString& XMLHttpRequest::responseText(ExceptionCode& ec) const
 {
+#if ENABLE(XHR_RESPONSE_BLOB)
+    if (m_asBlob)
+	 ec = INVALID_STATE_ERR;
+#else
+    UNUSED_PARAM(ec);
+#endif
     return m_responseText;
 }
 
-Document* XMLHttpRequest::responseXML() const
+Document* XMLHttpRequest::responseXML(ExceptionCode& ec) const
 {
+#if ENABLE(XHR_RESPONSE_BLOB)
+    if (m_asBlob) {
+	 ec = INVALID_STATE_ERR;
+	 return 0;
+    }
+#else
+    UNUSED_PARAM(ec);
+#endif