[webkit-reviews] review granted: [Bug 43658] Calling window.print() before the page is loaded results in a blank printed page : [Attachment 64371] Defer printing patch 3 - add a manual test.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 24 20:10:43 PDT 2010


Shinichiro Hamaji <hamaji at chromium.org> has granted Lei Zhang
<thestig at chromium.org>'s request for review:
Bug 43658: Calling window.print() before the page is loaded results in a blank
printed page
https://bugs.webkit.org/show_bug.cgi?id=43658

Attachment 64371: Defer printing patch 3 - add a manual test.
https://bugs.webkit.org/attachment.cgi?id=64371&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
Looks good. As I wrote in Comment 11, I'm not sure I'm a good reviewer for
loader code. Could you wait for a few days before you land this to see if no
one objects?

> DOMWindow::print() resets m_printDeferred.

Ah, I see. Thanks for clarification!


More information about the webkit-reviews mailing list