[webkit-reviews] review granted: [Bug 44537] WebKit2 should launch the WebProcess in 32-bit mode if the UIProcess is in 32-bit mode : [Attachment 65362] Patch

[bugzilla-daemon at webkit.org]

Mark Rowe (bdash) <mrowe at apple.com> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 44537: WebKit2 should launch the WebProcess in 32-bit mode if the UIProcess
is in 32-bit mode
https://bugs.webkit.org/show_bug.cgi?id=44537

Attachment 65362: Patch
https://bugs.webkit.org/attachment.cgi?id=65362&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
> +
> +    posix_spawnattr_t attr;
> +    posix_spawnattr_init(&attr);
> +
> +#if CPU(X86)
> +    // We spawn a 32-bit child process if the host is 32-bit. This allows
checking
> +    // the "Open in 32-bit mode" check box in the finder and getting a
32-bit WebProcess.

I don’t like the way this comment is worded.  It would be better to say
something about having the child process run as the same architecture as the
parent process.  The Finder in particular isn’t all that interesting here.

> +    cpu_type_t cpuTypes[] = { CPU_TYPE_X86 };    
> +#else
> +    cpu_type_t cpuTypes[] = { CPU_TYPE_ANY };
> +#endif
> +    size_t outCount = 0;
> +    posix_spawnattr_setbinpref_np(&attr, 1, cpuTypes, &outCount);

You could move this call in to the #if and drop the #else completely.

r=me